Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitpod-shared] Use "waitForSnapshot" to avoid disconnects #169

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Oct 21, 2021

Companion PR for: gitpod-io/gitpod#6144

The plan is to hold this PR until the other one ☝️ has been deployed.

@geropl geropl force-pushed the gpl/5862-snapshot branch from e31ddea to 6b972bb Compare October 21, 2021 15:44
@akosyakov
Copy link
Member

@geropl could you rebase and resolve conflicts please? 🙏 or would you be fine if i do it?

Server side already deployed in production correct?

@geropl
Copy link
Member Author

geropl commented Nov 19, 2021

could you rebase and resolve conflicts please

Uh, that was quick - did rebase yesterday 🙈

Server side already deployed in production correct?

Yes, since last week.

@geropl
Copy link
Member Author

geropl commented Nov 19, 2021

@akosyakov Should be up-to-date 👍

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked nicely, should be available in tomorrow insiders

@akosyakov akosyakov merged commit a8bac23 into gp-code/main Nov 19, 2021
@akosyakov akosyakov deleted the gpl/5862-snapshot branch November 19, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants